Skip to content

[Fix] Fix for issue #54#59

Merged
MartinBraquet merged 2 commits into
CompassConnections:mainfrom
O-Bots:main
Jun 12, 2026
Merged

[Fix] Fix for issue #54#59
MartinBraquet merged 2 commits into
CompassConnections:mainfrom
O-Bots:main

Conversation

@O-Bots

@O-Bots O-Bots commented Jun 12, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Added guards for username and display icons to prevent "Deleted user" from showing and allowing the page to load correctly

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of deleted or removed users in private messages, now properly waits for data to load before displaying placeholder content.

  • Refactor

    • Cleaned up import organization and test code formatting for improved readability.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

@O-Bots is attempting to deploy a commit to the Compass Team on Vercel.

A member of the Team first needs to authorize it.

@O-Bots O-Bots requested a review from MartinBraquet June 12, 2026 10:27
@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 951bc4a2-baf8-4c70-b2b7-ca4e0807c911

📥 Commits

Reviewing files that changed from the base of the PR and between dfd0dc9 and 6508cd2.

📒 Files selected for processing (2)
  • tests/e2e/web/specs/signIn.spec.ts
  • web/pages/messages/[channelId].tsx

Walkthrough

The PR contains two independent changes: E2E test callback signatures are reformatted from multiline to single-line destructuring for consistency, and the private messages page is updated to render null for undefined other-user states during loading instead of immediately showing a deleted-user placeholder.

Changes

E2E tests and messages page refinement

Layer / File(s) Summary
E2E test callback signature formatting
tests/e2e/web/specs/signIn.spec.ts		 Five test callback signatures for filter-matching tests are reformatted from multiline to single-line destructuring: education level, smoking preference, cannabis preference, political preference, and religion preference. No test logic or assertions are changed.
Private messages null rendering for undefined state
web/pages/messages/[channelId].tsx		 Hook imports are reformatted to multi-line destructuring. Header and username area conditional rendering is updated to return null when otherUsers is still undefined, instead of falling through to the deleted-user placeholder UI when members is empty.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • MartinBraquet
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "[Fix] Fix for issue #54" is vague and does not clearly describe the actual changes made. It uses generic phrasing without explaining what the fix addresses. Revise the title to be more descriptive, such as "Fix deleted user display guards in private chat header" or "Prevent premature deleted user placeholder in private messages."
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed due to a network error.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinBraquet

MartinBraquet commented Jun 12, 2026

Copy link
Copy Markdown
Member

Great!

@MartinBraquet MartinBraquet merged commit 8b93251 into CompassConnections:main Jun 12, 2026
4 of 5 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinBraquet MartinBraquet Awaiting requested review from MartinBraquet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@O-Bots @MartinBraquet